split of key/value pairs in css_parser.rb gobbles up values containing colons (:)
Reported by akfarrell | June 29th, 2009 @ 10:32 PM
I took this text from blueprint/src/print.css and added it, uncommented, to a custom css file which I specified in settings.yml:
/ a[href^="/"]:after { content: " (http://www.yourdomain.com" attr(href) ") "; } /
After running "ruby compress.rb -p [myprojectname]", I found that I had a print.css file that ended with:
a[href^="/"]:after {content:" (http;}
(I'm brand-new to Blueprint CSS, so perhaps this was a weird thing to do?)
A simple solution that seems correct to me is to make the following change in css_parser.rb (approx. line 45):
# split by property/val and append to rules array with correct d\
eclaration
- property, value = key_val_pair.split(':').map{|kv| kv.strip_side\
_space!}
+ property, value = key_val_pair.split(':',2).map{|kv| kv.strip_si\
de_space!}
break unless property && value
I've attached a patch. I saw your note about forking and resolving tickets but am not sure of the procedure, and since I'm a novice at CSS, ruby, and git, I suspect it would not gain you much. I hope this is useful and not overly cumbersome.
Comments and changes to this ticket
-
Josh Clayton June 29th, 2009 @ 10:32 PM
- → State changed from “new” to “resolved”
This has been resolved in commit http://github.com/joshuaclayton/blueprint-css/commit/e9e91bb94a0f49.... Thanks for the catch!
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
The Blueprint CSS framework
