Buttons plugin
Reported by Andriy Tyurnikov | April 25th, 2009 @ 08:30 PM
Scaling size of button becomes very non-trivial task, bcoz of usage of display:block; and float: left; padding-size in pixels, and line-height in both pixels and percents. Also button element is absent in reset (any reason?). Here is the line of CSS, which overrides framework settings and makes button scaling simple, and it follows convention of using em for size, and number for line-height:
a.button, button, button[type] { float:none; margin:0.5em 0; padding:0.5em; font-size:1em; line-height: 1.5; display:inline-block; }
Yes, this solution is not pixel-perfect for Firefox, but it is more flexible than existing approach. I am not sure if it works in MSIE - comments appreciated.
It would be nice to understand code commit policy of blueprint project. Thanks.
Comments and changes to this ticket
-
Christian Montoya August 20th, 2009 @ 03:34 PM
Reset is absent of most form elements because applying any CSS to them tends to cause problems.
Buttons is a plugin and has not received much work from the BP team.
I'll look into your solution soon. I know that the appearance is important for this plugin so that might explain why they were not designed to be scalable.
-
Andriy Tyurnikov August 20th, 2009 @ 04:00 PM
This plugin is an imported code, it is not designed as BP plugin.
My Windows machine is dead right now :(
I have branch on http://github.com/andriytyurnikov/blueprint-css/tree/master
buttons are kind of fixed in it(not pixel-perfect, but pretty good + em for font-size + button alignment is better too), but it still need to be tested in MSIE to get Josh's approval. -
Josh Clayton August 20th, 2009 @ 04:22 PM
- → State changed from “new” to “hold”
Andriy,
Once you have an OS on which you can test with IE6&7, send me screenshots; make sure to demonstrate all the different classes, with icons etc. I don't have a virtual server and we feel it's the person adding code's responsibility (in this instance, you) to both test the CSS for validity and browser support.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
The Blueprint CSS framework
